-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce context helpers API #8134
Open
PerfectSlayer
wants to merge
1
commit into
master
Choose a base branch
from
bbujon/context-helper
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 2 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~6f7c96dc14, baseline=1.46.0-SNAPSHOT~0da31f6ae9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1054884
Total [baseline] (10.459 s) : 0, 10458651
Agent [candidate] (1.056 s) : 0, 1055732
Total [candidate] (10.408 s) : 0, 10407834
section appsec
Agent [baseline] (1.193 s) : 0, 1193377
Total [baseline] (10.72 s) : 0, 10719712
Agent [candidate] (1.191 s) : 0, 1190658
Total [candidate] (10.748 s) : 0, 10748435
section iast
Agent [baseline] (1.182 s) : 0, 1182317
Total [baseline] (11.004 s) : 0, 11003622
Agent [candidate] (1.189 s) : 0, 1189470
Total [candidate] (10.951 s) : 0, 10950908
section profiling
Agent [baseline] (1.262 s) : 0, 1261753
Total [baseline] (10.876 s) : 0, 10875868
Agent [candidate] (1.256 s) : 0, 1255870
Total [candidate] (10.862 s) : 0, 10861680
gantt
title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~6f7c96dc14, baseline=1.46.0-SNAPSHOT~0da31f6ae9
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (713.721 ms) : 0, 713721
BytebuddyAgent [candidate] (714.324 ms) : 0, 714324
GlobalTracer [baseline] (255.71 ms) : 0, 255710
GlobalTracer [candidate] (256.08 ms) : 0, 256080
AppSec [baseline] (55.463 ms) : 0, 55463
AppSec [candidate] (55.95 ms) : 0, 55950
Remote Config [baseline] (729.435 µs) : 0, 729
Remote Config [candidate] (716.836 µs) : 0, 717
Telemetry [baseline] (14.234 ms) : 0, 14234
Telemetry [candidate] (13.716 ms) : 0, 13716
section appsec
BytebuddyAgent [baseline] (735.21 ms) : 0, 735210
BytebuddyAgent [candidate] (732.571 ms) : 0, 732571
GlobalTracer [baseline] (253.92 ms) : 0, 253920
GlobalTracer [candidate] (253.506 ms) : 0, 253506
AppSec [baseline] (170.863 ms) : 0, 170863
AppSec [candidate] (171.023 ms) : 0, 171023
Remote Config [baseline] (655.453 µs) : 0, 655
Remote Config [candidate] (660.439 µs) : 0, 660
Telemetry [baseline] (8.132 ms) : 0, 8132
Telemetry [candidate] (8.175 ms) : 0, 8175
IAST [baseline] (19.186 ms) : 0, 19186
IAST [candidate] (19.477 ms) : 0, 19477
section iast
BytebuddyAgent [baseline] (831.727 ms) : 0, 831727
BytebuddyAgent [candidate] (836.938 ms) : 0, 836938
GlobalTracer [baseline] (246.554 ms) : 0, 246554
GlobalTracer [candidate] (248.271 ms) : 0, 248271
AppSec [baseline] (58.141 ms) : 0, 58141
AppSec [candidate] (58.088 ms) : 0, 58088
Remote Config [baseline] (686.003 µs) : 0, 686
Remote Config [candidate] (675.411 µs) : 0, 675
Telemetry [baseline] (8.758 ms) : 0, 8758
Telemetry [candidate] (8.752 ms) : 0, 8752
IAST [baseline] (21.454 ms) : 0, 21454
IAST [candidate] (21.604 ms) : 0, 21604
section profiling
BytebuddyAgent [baseline] (706.598 ms) : 0, 706598
BytebuddyAgent [candidate] (703.68 ms) : 0, 703680
GlobalTracer [baseline] (351.547 ms) : 0, 351547
GlobalTracer [candidate] (350.967 ms) : 0, 350967
AppSec [baseline] (55.074 ms) : 0, 55074
AppSec [candidate] (53.789 ms) : 0, 53789
Remote Config [baseline] (676.277 µs) : 0, 676
Remote Config [candidate] (673.846 µs) : 0, 674
Telemetry [baseline] (8.916 ms) : 0, 8916
Telemetry [candidate] (8.786 ms) : 0, 8786
ProfilingAgent [baseline] (96.756 ms) : 0, 96756
ProfilingAgent [candidate] (95.976 ms) : 0, 95976
Profiling [baseline] (96.783 ms) : 0, 96783
Profiling [candidate] (96.004 ms) : 0, 96004
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~6f7c96dc14, baseline=1.46.0-SNAPSHOT~0da31f6ae9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1055179
Total [baseline] (8.611 s) : 0, 8611319
Agent [candidate] (1.063 s) : 0, 1063256
Total [candidate] (8.623 s) : 0, 8623192
section iast
Agent [baseline] (1.182 s) : 0, 1181585
Total [baseline] (9.177 s) : 0, 9176815
Agent [candidate] (1.182 s) : 0, 1182418
Total [candidate] (9.227 s) : 0, 9226737
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.18 s) : 0, 1179676
Total [baseline] (9.173 s) : 0, 9172822
Agent [candidate] (1.183 s) : 0, 1182792
Total [candidate] (9.214 s) : 0, 9213904
section iast_TELEMETRY_OFF
Agent [baseline] (1.184 s) : 0, 1184473
Total [baseline] (9.214 s) : 0, 9214418
Agent [candidate] (1.177 s) : 0, 1177358
Total [candidate] (9.173 s) : 0, 9172504
gantt
title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~6f7c96dc14, baseline=1.46.0-SNAPSHOT~0da31f6ae9
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (712.665 ms) : 0, 712665
BytebuddyAgent [candidate] (720.031 ms) : 0, 720031
GlobalTracer [baseline] (255.4 ms) : 0, 255400
GlobalTracer [candidate] (256.794 ms) : 0, 256794
AppSec [baseline] (55.325 ms) : 0, 55325
AppSec [candidate] (55.523 ms) : 0, 55523
Remote Config [baseline] (720.063 µs) : 0, 720
Remote Config [candidate] (719.997 µs) : 0, 720
Telemetry [baseline] (16.137 ms) : 0, 16137
Telemetry [candidate] (15.015 ms) : 0, 15015
section iast
BytebuddyAgent [baseline] (831.531 ms) : 0, 831531
BytebuddyAgent [candidate] (831.767 ms) : 0, 831767
GlobalTracer [baseline] (246.184 ms) : 0, 246184
GlobalTracer [candidate] (246.634 ms) : 0, 246634
AppSec [baseline] (57.8 ms) : 0, 57800
AppSec [candidate] (57.96 ms) : 0, 57960
IAST [baseline] (21.663 ms) : 0, 21663
IAST [candidate] (21.508 ms) : 0, 21508
Remote Config [baseline] (666.662 µs) : 0, 667
Remote Config [candidate] (679.916 µs) : 0, 680
Telemetry [baseline] (8.79 ms) : 0, 8790
Telemetry [candidate] (8.851 ms) : 0, 8851
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (829.814 ms) : 0, 829814
BytebuddyAgent [candidate] (831.776 ms) : 0, 831776
GlobalTracer [baseline] (246.258 ms) : 0, 246258
GlobalTracer [candidate] (246.853 ms) : 0, 246853
AppSec [baseline] (57.762 ms) : 0, 57762
AppSec [candidate] (57.997 ms) : 0, 57997
IAST [baseline] (21.511 ms) : 0, 21511
IAST [candidate] (21.628 ms) : 0, 21628
Remote Config [baseline] (666.888 µs) : 0, 667
Remote Config [candidate] (681.429 µs) : 0, 681
Telemetry [baseline] (8.694 ms) : 0, 8694
Telemetry [candidate] (8.818 ms) : 0, 8818
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (833.54 ms) : 0, 833540
BytebuddyAgent [candidate] (828.075 ms) : 0, 828075
GlobalTracer [baseline] (247.312 ms) : 0, 247312
GlobalTracer [candidate] (246.42 ms) : 0, 246420
AppSec [baseline] (58.092 ms) : 0, 58092
AppSec [candidate] (57.695 ms) : 0, 57695
IAST [baseline] (21.095 ms) : 0, 21095
IAST [candidate] (20.887 ms) : 0, 20887
Remote Config [baseline] (674.443 µs) : 0, 674
Remote Config [candidate] (665.727 µs) : 0, 666
Telemetry [baseline] (8.709 ms) : 0, 8709
Telemetry [candidate] (8.63 ms) : 0, 8630
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~6f7c96dc14, baseline=1.46.0-SNAPSHOT~0da31f6ae9
dateFormat X
axisFormat %s
section baseline
no_agent (1.35 ms) : 1330, 1369
. : milestone, 1350,
appsec (1.737 ms) : 1713, 1761
. : milestone, 1737,
appsec_no_iast (1.772 ms) : 1749, 1795
. : milestone, 1772,
iast (1.503 ms) : 1479, 1527
. : milestone, 1503,
profiling (1.494 ms) : 1471, 1517
. : milestone, 1494,
tracing (1.497 ms) : 1472, 1521
. : milestone, 1497,
section candidate
no_agent (1.349 ms) : 1329, 1368
. : milestone, 1349,
appsec (1.753 ms) : 1728, 1778
. : milestone, 1753,
appsec_no_iast (1.762 ms) : 1738, 1787
. : milestone, 1762,
iast (1.519 ms) : 1495, 1542
. : milestone, 1519,
profiling (1.508 ms) : 1485, 1530
. : milestone, 1508,
tracing (1.507 ms) : 1483, 1532
. : milestone, 1507,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~6f7c96dc14, baseline=1.46.0-SNAPSHOT~0da31f6ae9
dateFormat X
axisFormat %s
section baseline
no_agent (371.766 µs) : 351, 392
. : milestone, 372,
iast (498.977 µs) : 477, 520
. : milestone, 499,
iast_FULL (736.634 µs) : 715, 759
. : milestone, 737,
iast_GLOBAL (545.168 µs) : 523, 567
. : milestone, 545,
iast_HARDCODED_SECRET_DISABLED (507.966 µs) : 486, 530
. : milestone, 508,
iast_INACTIVE (452.52 µs) : 431, 474
. : milestone, 453,
iast_TELEMETRY_OFF (490.291 µs) : 469, 512
. : milestone, 490,
tracing (451.305 µs) : 430, 473
. : milestone, 451,
section candidate
no_agent (381.3 µs) : 362, 401
. : milestone, 381,
iast (500.522 µs) : 479, 522
. : milestone, 501,
iast_FULL (736.274 µs) : 714, 758
. : milestone, 736,
iast_GLOBAL (550.39 µs) : 528, 573
. : milestone, 550,
iast_HARDCODED_SECRET_DISABLED (502.128 µs) : 480, 524
. : milestone, 502,
iast_INACTIVE (454.505 µs) : 433, 476
. : milestone, 455,
iast_TELEMETRY_OFF (494.241 µs) : 472, 517
. : milestone, 494,
tracing (444.167 µs) : 423, 465
. : milestone, 444,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~6f7c96dc14, baseline=1.46.0-SNAPSHOT~0da31f6ae9
dateFormat X
axisFormat %s
section baseline
no_agent (14.969 s) : 14969000, 14969000
. : milestone, 14969000,
appsec (14.99 s) : 14990000, 14990000
. : milestone, 14990000,
iast (18.968 s) : 18968000, 18968000
. : milestone, 18968000,
iast_GLOBAL (17.791 s) : 17791000, 17791000
. : milestone, 17791000,
profiling (15.148 s) : 15148000, 15148000
. : milestone, 15148000,
tracing (14.81 s) : 14810000, 14810000
. : milestone, 14810000,
section candidate
no_agent (15.284 s) : 15284000, 15284000
. : milestone, 15284000,
appsec (15.085 s) : 15085000, 15085000
. : milestone, 15085000,
iast (18.866 s) : 18866000, 18866000
. : milestone, 18866000,
iast_GLOBAL (17.877 s) : 17877000, 17877000
. : milestone, 17877000,
profiling (15.002 s) : 15002000, 15002000
. : milestone, 15002000,
tracing (14.834 s) : 14834000, 14834000
. : milestone, 14834000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~6f7c96dc14, baseline=1.46.0-SNAPSHOT~0da31f6ae9
dateFormat X
axisFormat %s
section baseline
no_agent (1.481 ms) : 1470, 1493
. : milestone, 1481,
appsec (2.373 ms) : 2331, 2416
. : milestone, 2373,
iast (2.115 ms) : 2061, 2170
. : milestone, 2115,
iast_GLOBAL (2.166 ms) : 2111, 2221
. : milestone, 2166,
profiling (1.967 ms) : 1924, 2010
. : milestone, 1967,
tracing (1.953 ms) : 1911, 1995
. : milestone, 1953,
section candidate
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (2.376 ms) : 2333, 2419
. : milestone, 2376,
iast (2.116 ms) : 2062, 2171
. : milestone, 2116,
iast_GLOBAL (2.155 ms) : 2100, 2210
. : milestone, 2155,
profiling (2.005 ms) : 1960, 2050
. : milestone, 2005,
tracing (1.953 ms) : 1911, 1995
. : milestone, 1953,
|
mcculls
reviewed
Dec 31, 2024
mcculls
reviewed
Dec 31, 2024
components/context/src/main/java/datadog/context/ContextHelpers.java
Outdated
Show resolved
Hide resolved
PerfectSlayer
force-pushed
the
bbujon/context-helper
branch
from
January 2, 2025 09:24
a41844e
to
d1483fa
Compare
mcculls
force-pushed
the
bbujon/context-helper
branch
from
January 15, 2025 20:54
d1483fa
to
6f7c96d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR introduces few helper methods to help manipulate context and carrier collections.
Motivation
This should help with Context adoption and make its usage simpler while not enriching Context interface itself.
Additional Notes
The helper API comes from the Context API scratchpad discussions and are open to feedback.
The more we get, the best they will be.
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: LANGPLAT-39